Skip to content

Commit

Permalink
[SPARK-9758] [TEST] [SQL] Compilation issue for hive test / wrong pac…
Browse files Browse the repository at this point in the history
…kage?

Move `test.org.apache.spark.sql.hive` package tests to apparent intended `org.apache.spark.sql.hive` as they don't intend to test behavior from outside org.apache.spark.*

Alternate take, per discussion at #8051
I think this is what vanzin and I had in mind but also CC rxin to cross-check, as this does indeed depend on whether these tests were accidentally in this package or not. Testing from a `test.org.apache.spark` package is legitimate but didn't seem to be the intent here.

Author: Sean Owen <sowen@cloudera.com>

Closes #8307 from srowen/SPARK-9758.

(cherry picked from commit cb2d2e1)
Signed-off-by: Sean Owen <sowen@cloudera.com>
  • Loading branch information
srowen committed Aug 24, 2015
1 parent d36f351 commit 9223443
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

package test.org.apache.spark.sql.hive;
package org.apache.spark.sql.hive;

import java.io.IOException;
import java.util.ArrayList;
Expand All @@ -31,10 +31,8 @@
import org.apache.spark.sql.expressions.Window;
import org.apache.spark.sql.expressions.UserDefinedAggregateFunction;
import static org.apache.spark.sql.functions.*;
import org.apache.spark.sql.hive.HiveContext;
import org.apache.spark.sql.hive.test.TestHive$;
import org.apache.spark.sql.expressions.UserDefinedAggregateFunction;
import test.org.apache.spark.sql.hive.aggregate.MyDoubleSum;
import org.apache.spark.sql.hive.aggregate.MyDoubleSum;

public class JavaDataFrameSuite {
private transient JavaSparkContext sc;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

package test.org.apache.spark.sql.hive;
package org.apache.spark.sql.hive;

import java.io.File;
import java.io.IOException;
Expand All @@ -37,7 +37,6 @@
import org.apache.spark.sql.DataFrame;
import org.apache.spark.sql.QueryTest$;
import org.apache.spark.sql.Row;
import org.apache.spark.sql.hive.HiveContext;
import org.apache.spark.sql.hive.test.TestHive$;
import org.apache.spark.sql.types.DataTypes;
import org.apache.spark.sql.types.StructField;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

package test.org.apache.spark.sql.hive.aggregate;
package org.apache.spark.sql.hive.aggregate;

import java.util.ArrayList;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

package test.org.apache.spark.sql.hive.aggregate;
package org.apache.spark.sql.hive.aggregate;

import java.util.ArrayList;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import org.apache.spark.sql.execution.aggregate
import org.apache.spark.sql.hive.test.TestHive
import org.apache.spark.sql.test.SQLTestUtils
import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType}
import _root_.test.org.apache.spark.sql.hive.aggregate.{MyDoubleAvg, MyDoubleSum}
import org.apache.spark.sql.hive.aggregate.{MyDoubleAvg, MyDoubleSum}

abstract class AggregationQuerySuite extends QueryTest with SQLTestUtils with BeforeAndAfterAll {
override def _sqlContext: SQLContext = TestHive
Expand Down

0 comments on commit 9223443

Please sign in to comment.