Skip to content

Commit

Permalink
fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
mgaido91 committed Mar 10, 2018
1 parent d8a1190 commit 9e2d993
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ trait Predicate extends Expression {
override def dataType: DataType = BooleanType
}


trait PredicateHelper {
protected def splitConjunctivePredicates(condition: Expression): Seq[Expression] = {
condition match {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ trait QueryPlanConstraints { self: LogicalPlan =>
*/
protected def inferIsNotNullConstraints(constraint: Expression): Seq[Expression] =
constraint match {
// When the root is IsNotNull, we can push IsNotNull thro0ugh the child null intolerant
// When the root is IsNotNull, we can push IsNotNull through the child null intolerant
// expressions
case IsNotNull(expr) => scanNullIntolerantAttribute(expr).map(IsNotNull(_))
// Constraints always return true for all the inputs. That means, null will never be returned.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,9 @@ case class Join(
case _ => resolvedExceptNatural
}

/**
* Returns additional constraints which are not enforced on the result of join operations, but
* which can be enforced either on the left or the right side
*/
override protected def constructAllConstraints: Set[Expression] = {
// additional constraints which are not enforced on the result of join operations, but can be
// enforced either on the left or the right side
val additionalConstraints = joinType match {
case LeftAnti | LeftOuter if condition.isDefined =>
splitConjunctivePredicates(condition.get).flatMap(inferIsNotNullConstraints).filter(
Expand Down

0 comments on commit 9e2d993

Please sign in to comment.