fix

apache · Jul 14, 2020 · a956144 · a956144
1 parent c129a54
commit a956144
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
@@ -265,9 +265,10 @@ case class RefreshFunctionCommand(
       // register overwrite function.
       val func = catalog.getFunctionMetadata(identifier)
       catalog.registerFunction(func, true)
-    } else {
-      // function is not exists, clear cached function.
+    } else if (catalog.isRegisteredFunction(identifier)) {
+      // clear cached function.
       catalog.unregisterFunction(identifier, true)
+    } else {
       throw new NoSuchFunctionException(identifier.database.get, functionName)
     }
 

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
@@ -3058,9 +3058,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
 
       spark.sessionState.catalog.externalCatalog.dropFunction("default", "func1")
       assert(spark.sessionState.catalog.isRegisteredFunction(func))
-      intercept[NoSuchFunctionException] {
-        sql("REFRESH FUNCTION func1")
-      }
+      sql("REFRESH FUNCTION func1")
       assert(!spark.sessionState.catalog.isRegisteredFunction(func))
 
       val function = CatalogFunction(func, "test.non.exists.udf", Seq.empty)