Skip to content

Commit

Permalink
Disable some overly-verbose logs that rendered DEBUG useless.
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshRosen committed May 11, 2015
1 parent f780fb1 commit b57c17f
Showing 1 changed file with 4 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ public TaskMemoryManager(ExecutorMemoryManager executorMemoryManager) {
* intended for allocating large blocks of memory that will be shared between operators.
*/
public MemoryBlock allocatePage(long size) {
if (logger.isTraceEnabled()) {
logger.trace("Allocating {} byte page", size);
}
if (size >= (1L << 51)) {
throw new IllegalArgumentException("Cannot allocate a page with more than 2^51 bytes");
}
Expand All @@ -120,8 +117,8 @@ public MemoryBlock allocatePage(long size) {
final MemoryBlock page = executorMemoryManager.allocate(size);
page.pageNumber = pageNumber;
pageTable[pageNumber] = page;
if (logger.isDebugEnabled()) {
logger.debug("Allocate page number {} ({} bytes)", pageNumber, size);
if (logger.isTraceEnabled()) {
logger.trace("Allocate page number {} ({} bytes)", pageNumber, size);
}
return page;
}
Expand All @@ -130,18 +127,15 @@ public MemoryBlock allocatePage(long size) {
* Free a block of memory allocated via {@link TaskMemoryManager#allocatePage(long)}.
*/
public void freePage(MemoryBlock page) {
if (logger.isTraceEnabled()) {
logger.trace("Freeing page number {} ({} bytes)", page.pageNumber, page.size());
}
assert (page.pageNumber != -1) :
"Called freePage() on memory that wasn't allocated with allocatePage()";
executorMemoryManager.free(page);
synchronized (this) {
allocatedPages.clear(page.pageNumber);
}
pageTable[page.pageNumber] = null;
if (logger.isDebugEnabled()) {
logger.debug("Freed page number {} ({} bytes)", page.pageNumber, page.size());
if (logger.isTraceEnabled()) {
logger.trace("Freed page number {} ({} bytes)", page.pageNumber, page.size());
}
}

Expand Down

0 comments on commit b57c17f

Please sign in to comment.