Address more PR comments

* Remove extra space in tests * Add cause to thrown exceptions
apache · May 30, 2018 · b7ff38f · b7ff38f
1 parent c1b4d16
commit b7ff38f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/src/main/scala/org/apache/spark/SparkConf.scala b/core/src/main/scala/org/apache/spark/SparkConf.scala
@@ -483,9 +483,11 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
       getValue
     } catch {
       case e: NumberFormatException =>
+        // NumberFormatException doesn't have a constructor that takes a cause for some reason.
         throw new NumberFormatException(s"Illegal value for config key $key: ${e.getMessage}")
+            .initCause(e)
       case e: IllegalArgumentException =>
-        throw new IllegalArgumentException(s"Illegal value for config key $key: ${e.getMessage}")
+        throw new IllegalArgumentException(s"Illegal value for config key $key: ${e.getMessage}", e)
     }
   }
 

diff --git a/core/src/test/scala/org/apache/spark/SparkConfSuite.scala b/core/src/test/scala/org/apache/spark/SparkConfSuite.scala
@@ -366,7 +366,7 @@ class SparkConfSuite extends SparkFunSuite with LocalSparkContext with ResetSyst
       val key = "SomeKey"
       val conf = new SparkConf()
       conf.set(key, "SomeInvalidValue")
-      val thrown = intercept [IllegalArgumentException] {
+      val thrown = intercept[IllegalArgumentException] {
         getValue(conf, key)
       }
       assert(thrown.getMessage.contains(key))