Skip to content

Commit

Permalink
[SPARK-12821][BUILD] Style checker should run when some configuration…
Browse files Browse the repository at this point in the history
… files for style are modified but any source files are not.

When running the `run-tests` script, style checkers run only when any source files are modified but they should run when configuration files related to style are modified.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #10754 from sarutak/SPARK-12821.
  • Loading branch information
sarutak authored and JoshRosen committed Jan 14, 2016
1 parent 902667f commit bcc7373
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions dev/run-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -529,9 +529,14 @@ def main():
run_apache_rat_checks()

# style checks
if not changed_files or any(f.endswith(".scala") for f in changed_files):
if not changed_files or any(f.endswith(".scala")
or f.endswith("scalastyle-config.xml")
for f in changed_files):
run_scala_style_checks()
if not changed_files or any(f.endswith(".java") for f in changed_files):
if not changed_files or any(f.endswith(".java")
or f.endswith("checkstyle.xml")
or f.endswith("checkstyle-suppressions.xml")
for f in changed_files):
# run_java_style_checks()
pass
if not changed_files or any(f.endswith(".py") for f in changed_files):
Expand Down

0 comments on commit bcc7373

Please sign in to comment.