Skip to content

Commit

Permalink
[SPARK-27869][CORE] Redact sensitive information in System Properties…
Browse files Browse the repository at this point in the history
… from UI

## What changes were proposed in this pull request?

Currently system properties are not redacted. This PR fixes that, so that any credentials passed as System properties are redacted as well.

## How was this patch tested?

Manual test. Run the following and see the UI.
```
bin/spark-shell --conf 'spark.driver.extraJavaOptions=-DMYSECRET=app'
```

Closes #24733 from aaruna/27869.

Authored-by: Aaruna <aaruna.godthi@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
aaruna authored and dongjoon-hyun committed May 29, 2019
1 parent 19aaf0f commit bfa7f11
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ private[ui] class EnvironmentPage(
Utils.redact(conf, appEnv.sparkProperties.sorted), fixedWidth = true)
val hadoopPropertiesTable = UIUtils.listingTable(propertyHeader, propertyRow,
Utils.redact(conf, appEnv.hadoopProperties.sorted), fixedWidth = true)
val systemPropertiesTable = UIUtils.listingTable(
propertyHeader, propertyRow, appEnv.systemProperties.sorted, fixedWidth = true)
val systemPropertiesTable = UIUtils.listingTable(propertyHeader, propertyRow,
Utils.redact(conf, appEnv.systemProperties.sorted), fixedWidth = true)
val classpathEntriesTable = UIUtils.listingTable(
classPathHeaders, classPathRow, appEnv.classpathEntries.sorted, fixedWidth = true)
val content =
Expand Down

0 comments on commit bfa7f11

Please sign in to comment.