Skip to content

Commit

Permalink
[SPARK-9307][CORE][SPARK] Logging: Make it either stable or private
Browse files Browse the repository at this point in the history
Make Logging private[spark]. Pretty much all there is to it.

Author: Sean Owen <sowen@cloudera.com>

Closes #11103 from srowen/SPARK-9307.
  • Loading branch information
srowen committed Feb 10, 2016
1 parent e834e42 commit c0b71e0
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions core/src/main/scala/org/apache/spark/Logging.scala
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,15 @@ import org.apache.log4j.{Level, LogManager, PropertyConfigurator}
import org.slf4j.{Logger, LoggerFactory}
import org.slf4j.impl.StaticLoggerBinder

import org.apache.spark.annotation.Private
import org.apache.spark.util.Utils

/**
* Utility trait for classes that want to log data. Creates a SLF4J logger for the class and allows
* logging messages at different levels using methods that only evaluate parameters lazily if the
* log level is enabled.
*
* NOTE: DO NOT USE this class outside of Spark. It is intended as an internal utility.
* This will likely be changed or removed in future releases.
*/
@Private
trait Logging {
private[spark] trait Logging {

// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
@transient private var log_ : Logger = null
Expand Down

0 comments on commit c0b71e0

Please sign in to comment.