Skip to content

Commit

Permalink
[SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom …
Browse files Browse the repository at this point in the history
…file

### What changes were proposed in this pull request?

This PR aims to unify two K8s version variables in two `pom.xml`s into one. `kubernetes-client.version` is correct because the artifact ID is `kubernetes-client`.

```
kubernetes.client.version (kubernetes/core module)
kubernetes-client.version (kubernetes/integration-test module)
```

### Why are the changes needed?

Having two variables for the same value is confusing and inconvenient when we upgrade K8s versions.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs. (The compilation test passes are enough.)

Closes #32531 from dongjoon-hyun/SPARK-35394.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
dongjoon-hyun committed May 13, 2021
1 parent 17b59a9 commit dd54649
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions pom.xml
Expand Up @@ -204,6 +204,7 @@
<arrow.version>2.0.0</arrow.version>
<!-- org.fusesource.leveldbjni will be used except on arm64 platform. -->
<leveldbjni.group>org.fusesource.leveldbjni</leveldbjni.group>
<kubernetes-client.version>5.3.1</kubernetes-client.version>

<test.java.home>${java.home}</test.java.home>

Expand Down
4 changes: 1 addition & 3 deletions resource-managers/kubernetes/core/pom.xml
Expand Up @@ -29,8 +29,6 @@
<name>Spark Project Kubernetes</name>
<properties>
<sbt.project.name>kubernetes</sbt.project.name>
<!-- Note: Please update the kubernetes client version in kubernetes/integration-tests/pom.xml -->
<kubernetes.client.version>5.3.1</kubernetes.client.version>
</properties>

<dependencies>
Expand All @@ -57,7 +55,7 @@
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-client</artifactId>
<version>${kubernetes.client.version}</version>
<version>${kubernetes-client.version}</version>
<exclusions>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
Expand Down
1 change: 0 additions & 1 deletion resource-managers/kubernetes/integration-tests/pom.xml
Expand Up @@ -28,7 +28,6 @@
<properties>
<download-maven-plugin.version>1.3.0</download-maven-plugin.version>
<extraScalaTestArgs></extraScalaTestArgs>
<kubernetes-client.version>5.3.1</kubernetes-client.version>
<sbt.project.name>kubernetes-integration-tests</sbt.project.name>

<!-- Integration Test Configuration Properties -->
Expand Down

0 comments on commit dd54649

Please sign in to comment.