Skip to content

Commit

Permalink
[SPARK-45870][INFRA] Upgrade action/checkout to v4
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
The pr aims to upgrade action/checkout from v3(node16) to v4(node20) (point to v4.1.1 now).

### Why are the changes needed?
- After V4.0.0, the action/checkout default runtime is node20.
   <img width="577" alt="image" src="https://github.com/apache/spark/assets/15246973/5e261225-9f72-46f8-b10a-7820919810b2">

- Node 16 has reached its [end of life](https://github.com/nodejs/Release/#end-of-life-releases)
   <img width="946" alt="image" src="https://github.com/apache/spark/assets/15246973/64a6c6bf-7b70-418e-b053-2b156484a200">
   https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #43744 from panbingkun/github_checkout_action.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
panbingkun authored and dongjoon-hyun committed Nov 12, 2023
1 parent 2605b87 commit eccf076
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 18 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
SPARK_LOCAL_IP: localhost
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to get diff files
with:
fetch-depth: 0
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
key: tpcds-${{ hashFiles('.github/workflows/benchmark.yml', 'sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala') }}
- name: Checkout tpcds-kit repository
if: steps.cache-tpcds-sf-1.outputs.cache-hit != 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: databricks/tpcds-kit
ref: 2a5078a782192ddb6efbcead8de9973d6ab4f069
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
SPARK_TPCDS_DATA: ${{ github.workspace }}/tpcds-sf-1
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to get diff files
with:
fetch-depth: 0
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
}}
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:
SKIP_PACKAGING: true
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to fetch changed files
with:
fetch-depth: 0
Expand Down Expand Up @@ -302,7 +302,7 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to fetch changed files
with:
fetch-depth: 0
Expand Down Expand Up @@ -381,7 +381,7 @@ jobs:
BRANCH: ${{ inputs.branch }}
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to fetch changed files
with:
fetch-depth: 0
Expand Down Expand Up @@ -496,7 +496,7 @@ jobs:
SKIP_PACKAGING: true
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to fetch changed files
with:
fetch-depth: 0
Expand Down Expand Up @@ -564,7 +564,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down Expand Up @@ -604,7 +604,7 @@ jobs:
image: ${{ needs.precondition.outputs.image_url }}
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down Expand Up @@ -786,7 +786,7 @@ jobs:
timeout-minutes: 300
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down Expand Up @@ -841,7 +841,7 @@ jobs:
SPARK_LOCAL_IP: localhost
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down Expand Up @@ -883,7 +883,7 @@ jobs:
key: tpcds-${{ hashFiles('.github/workflows/build_and_test.yml', 'sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala') }}
- name: Checkout tpcds-kit repository
if: steps.cache-tpcds-sf-1.outputs.cache-hit != 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: databricks/tpcds-kit
ref: 2a5078a782192ddb6efbcead8de9973d6ab4f069
Expand Down Expand Up @@ -946,7 +946,7 @@ jobs:
SKIP_PACKAGING: true
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down Expand Up @@ -1006,7 +1006,7 @@ jobs:
timeout-minutes: 300
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
repository: apache/spark
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_infra_images_cache.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
packages: write
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
- name: Set up Docker Buildx
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maven_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
GITHUB_PREV_SHA: ${{ github.event.before }}
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
# In order to fetch changed files
with:
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
branch: ${{ fromJSON( inputs.branch || '["master", "branch-3.5", "branch-3.4", "branch-3.3"]' ) }}
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
- name: Cache Maven local repository
Expand Down

0 comments on commit eccf076

Please sign in to comment.