-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12351][MESOS]Add documentation about submitting Spark with mesos cluster mode. #10086
Conversation
@@ -132,9 +144,10 @@ The master URL passed to Spark can be in one of the following formats: | |||
<tr><td> <code>mesos://HOST:PORT</code> </td><td> Connect to the given <a href="running-on-mesos.html">Mesos</a> cluster. | |||
The port must be whichever one your is configured to use, which is 5050 by default. | |||
Or, for a Mesos cluster using ZooKeeper, use <code>mesos://zk://...</code>. | |||
To submit with <code>--deploy-mode cluster</code>, the HOST:PORT should be configured to connect to the MesosClusterDispatcher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do they know at this point what a MesosClusterDispatcher
is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tnachen can you update this assuming the user doesn't know anything about the dispatcher?
looks alright |
Test build #47028 has finished for PR 10086 at commit
|
@dragos you mentioned you had difficulty running mesos in cluster mode. Does this additional documentation help? What were the issues you ran into? |
@andrewor14 I don't tihnk this doc helps his problem, he's running into issues where Spark configuration is not being passed down. I'm pushing a new update here. |
448d706
to
5d612d0
Compare
Test build #47158 has finished for PR 10086 at commit
|
@andrewor14 pushed an update today, PTAL |
Thanks, this is a good example! Can you please update also |
@andrewor14 the issue in the other PR is not due to missing docs, unfortunately. I will post my errors in that PR (I reached out to Tim via Slack earlier, but maybe it makes sense to have such discussions in the open) |
5d612d0
to
952f116
Compare
@dragos just updated the docs |
Test build #47318 has finished for PR 10086 at commit
|
LGTM |
passing in the Mesos master url (e.g: mesos://host:5050). | ||
passing in the Mesos master url (e.g: mesos://host:5050). This starts the MesosClusterDispatcher as an daemon running on the host. | ||
|
||
If you like to run the MesosClusterDispatcher with Marathon, you need to run the MesosClusterDispatcher in the foreground (i.e: `bin/spark-class org.apache.spark.deploy.mesos.MesosClusterDispatcher`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits: "an daemon" -> "a daemon", url -> URL, "i.e" -> "i.e.". You might back-tick MesosClusterDispatcher too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I would backtick the dispatcher
@tnachen can you address the comments? I'll merge this once you do so. |
Ping @tnachen |
952f116
to
7f8d7b6
Compare
@srowen @andrewor14 sorry for the delay, it's updated now. |
Test build #47741 has finished for PR 10086 at commit
|
Last but not least, should we go ahead and make a JIRA for this? it's pretty minor but not trivial |
Created jira and updated title @srowen |
Merged into master and 1.6 |
Adding more documentation about submitting jobs with mesos cluster mode.