Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming][Minor] Fix typo in function name of StateImpl #10305

Closed
wants to merge 1 commit into from
Closed

[Streaming][Minor] Fix typo in function name of StateImpl #10305

wants to merge 1 commit into from

Conversation

jerryshao
Copy link
Contributor

cc\ @tdas @zsxwing , please review. Thanks a lot.

@SparkQA
Copy link

SparkQA commented Dec 15, 2015

Test build #47723 has finished for PR 10305 at commit 7293243.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor

holdenk commented Dec 15, 2015

lgtm (also someone needs to find a way to get rid of 3ourroom's junk comments).

@jerryshao
Copy link
Contributor Author

Thanks @holdenk . Not sure why there's so many junk comments, is it also existed in other PRs?

@BenFradet
Copy link
Contributor

Yes, quite a few actually.

@srowen
Copy link
Member

srowen commented Dec 15, 2015

(Already reported this user to Github; others can do the same)
LGTM

@zsxwing
Copy link
Member

zsxwing commented Dec 15, 2015

LGTM

@zsxwing
Copy link
Member

zsxwing commented Dec 15, 2015

Merging to master and 1.6. Thanks @jerryshao

@asfgit asfgit closed this in bc1ff9f Dec 15, 2015
asfgit pushed a commit that referenced this pull request Dec 15, 2015
@jerryshao @zsxwing
[STREAMING][MINOR] Fix typo in function name of StateImpl
23c8846 
cc\ tdas zsxwing , please review. Thanks a lot.

Author: jerryshao <sshao@hortonworks.com>

Closes #10305 from jerryshao/fix-typo-state-impl.

(cherry picked from commit bc1ff9f)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@jerryshao @SparkQA @holdenk @BenFradet @srowen @zsxwing