[SPARK-12387][SQL]JDBC IN operator push down #10345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -269,6 +269,13 @@ private[sql] class JDBCRDD( | |||
| case stringValue: String => s"'${escapeSql(stringValue)}'" | |||
| case timestampValue: Timestamp => "'" + timestampValue + "'" | |||
| case dateValue: Date => "'" + dateValue + "'" | |||
| case objectValue: Array[Object] => { | |||
| val str = objectValue.map { | |||
| case string: String => "'" + string + "'" | |||
There was a problem hiding this comment.
change line 274 to:
case stringValue: String => s"'${escapeSql(stringValue)}'"
There was a problem hiding this comment.
@bomeng
Thanks a lot for your comment. I will change.
|
Close for now. Will put the filter changes in one PR so it's easier to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will push down SQL IN operator such as the following to JDBC datasource
SELECT column_name(s)
FROM table_name
WHERE column_name IN (value1,value2,...)