Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12421][SQL] Prevent Internal/External row from exposing state. #10553

Closed
wants to merge 3 commits into from

Conversation

hvanhovell
Copy link
Contributor

It is currently possible to change the values of the supposedly immutable GenericRow and GenericInternalRow classes. This is caused by the fact that scala's ArrayOps toArray (returned by calling toSeq) will return the backing array instead of a copy. This PR fixes this problem.

This PR was inspired by #10374 by @apo1.

cc @apo1 @sarutak @marmbrus @cloud-fan @nongli (everyone in the previous conversation).

@SparkQA
Copy link

SparkQA commented Jan 2, 2016

Test build #48581 has finished for PR 10553 at commit 632b5dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 2, 2016

Test build #48582 has finished for PR 10553 at commit daa123b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 2, 2016

Test build #48584 has finished for PR 10553 at commit 4d5d162.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

marmbrus commented Jan 4, 2016

Thanks, merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants