-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12634][Python][MLlib][DOC] Update param descriptions for tree.py #10601
Conversation
@vijaykiran thanks for the style fixes. cc @jkbradley |
I just added a note to the parent JIRA about a formatting issue affecting all 5 PRs: [https://issues.apache.org/jira/browse/SPARK-11219?focusedCommentId=15090225&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15090225] |
1c9ab61
to
c1558c8
Compare
Ping @jkbradley / @BryanCutler |
(default: 32) | ||
:param seed: Random seed for bootstrapping and choosing feature | ||
subsets. | ||
:param data: Training dataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Training dataset:" should be on the next line
Thanks @vijaykiran , this is looking much better! I made a few comments for correction, and could you also update the PR title and description to indicate that this is for tree.py? |
Updates the `param` descriptions to be consistent. See [SPARK-11219] for more details.
- Update fill-column to 100 on parameter descriptions.
c1558c8
to
36be47c
Compare
@BryanCutler ping! Can you check one more time ? returns are styled now. |
LGTM, ping @jkbradley |
ok to test |
Test build #50150 has finished for PR 10601 at commit
|
@vijaykiran Could you fix the doc build warnings in
|
:return: RandomForestModel that can be used for prediction | ||
:param data: | ||
Training dataset: RDD of LabeledPoint. Labels should take values | ||
{0, 1, ..., numClasses-1}.:param numClasses: Number of classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the numClasses
param got put in with the previous description
Updates the
param
descriptions, in mllib/tree.py, to be consistent. See [SPARK-11219] formore details.