[SPARK-12317][SQL] Support units (m,k,g) in SQLConf #10629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert(sqlContext.conf.targetPostShuffleInputSize === -1) | ||
|
|
||
| // Test overflow exception | ||
| intercept[IllegalArgumentException] { |
There was a problem hiding this comment.
can you indent the following properly?
There was a problem hiding this comment.
otherwise it will fail the style checker
|
Jenkins, ok to test. |
|
Test build #2349 has finished for PR 10629 at commit
|
|
I'm going to merge this and fix the indentation myself. Thanks. |
|
@rxin I am so sorry that I didn't reply earlier. The code passed the style check, I copied the code from the existing codes, and I thought the indentation 2 is fine. So I am not sure how to make changes. But appreciated your help. Next time, I will raise the questions more quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continue from previous closed PR 10314.
In this PR, SHUFFLE_TARGET_POSTSHUFFLE_INPUT_SIZE will be taken memory string conventions as input.
For example, the user can now specify 10g for SHUFFLE_TARGET_POSTSHUFFLE_INPUT_SIZE in SQLConf file.
@marmbrus @srowen : Can you help review this code changes ? Thanks.