[SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) #10697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthson
changed the title
|
ok to test |
| @@ -71,7 +71,8 @@ private[feature] trait CountVectorizerParams extends Params with HasInputCol wit | |||
| /** Validates and transforms the input schema. */ | |||
| protected def validateAndTransformSchema(schema: StructType): StructType = { | |||
| validateParams() | |||
| SchemaUtils.checkColumnType(schema, $(inputCol), new ArrayType(StringType, true)) | |||
| val typeCandidates = List(new ArrayType(StringType, true), new ArrayType(StringType, false)) | |||
There was a problem hiding this comment.
minor: new is not necessary since ArrayType is a case class
|
LGTM pending Jenins |
|
Test build #51163 has finished for PR 10697 at commit
|
|
Merged into master. Thanks! @Earthson I didn't merge it into branch-1.6 because |
|
@mengxr ok, I'll have a look:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-12746