[SPARK-10985][CORE] Avoid passing evicted blocks throughout BlockManager #10776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #49484 has finished for PR 10776 at commit
|
| Option(TaskContext.get()).foreach { tc => | ||
| val metrics = tc.taskMetrics() | ||
| val lastUpdatedBlocks = metrics.updatedBlocks.getOrElse(Seq[(BlockId, BlockStatus)]()) | ||
| metrics.updatedBlocks = Some(lastUpdatedBlocks ++ evictedBlocks.toSeq) |
There was a problem hiding this comment.
I plan to move this call closer to the eviction site itself (i.e. perform this call inside either the memory store or the block manager itself rather than here).
| case Left(arr) => | ||
| // We have successfully unrolled the entire partition, so cache it in memory | ||
| updatedBlocks ++= |
There was a problem hiding this comment.
This update has been pushed further down into the BlockManager code. See the changes to doPut(). The same holds for the putIterator() call above.
JoshRosen
changed the title
|
@andrewor14 @rxin, this should now be ready for review. |
|
Test build #49581 has finished for PR 10776 at commit
|
| @@ -847,7 +854,7 @@ private[spark] class BlockManager( | |||
| .format(blockId, Utils.getUsedTimeMs(startTimeMs))) | |||
| } | |||
|
|
|||
| updatedBlocks | |||
| marked | |||
There was a problem hiding this comment.
not clear what this means, maybe success or putSuccess?
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors portions of the BlockManager and CacheManager in order to avoid having to pass
evictedBlockslists throughout the code. It appears that these lists were only consumed byTaskContext.taskMetrics, so the new code now directly updates the metrics from the lower-level BlockManager methods.