[SPARK-12855][SQL] Remove parser dialect developer API #10801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hvanhovell |
|
BTW - I kept the ParserDialect trait, although I'm thinking we should rename it something else (e.g. ParserInterface?). I didn't change the DDLParser because I'm assuming we will remove it soon (replaced by the Hive one). |
|
Test build #2390 has finished for PR 10801 at commit
|
|
Test build #49573 has finished for PR 10801 at commit
|
|
Test build #2391 has finished for PR 10801 at commit
|
|
Test build #49574 has finished for PR 10801 at commit
|
| } | ||
| } | ||
| @transient | ||
| protected[sql] override val sqlParser: ParserDialect = new ExtendedHiveQlParser(this) |
There was a problem hiding this comment.
We need to add the SparkSQLParser here: new SparkSQLParser(new ExtendedHiveQlParser(this))
|
Test build #49610 has finished for PR 10801 at commit
|
|
LGTM |
|
Thanks - merging this in. |
asfgit
pushed a commit
that referenced
this pull request
Jan 19, 2016
Based on discussions in #10801, I'm submitting a pull request to rename ParserDialect to ParserInterface. Author: Reynold Xin <rxin@databricks.com> Closes #10817 from rxin/SPARK-12889.
asfgit
pushed a commit
that referenced
this pull request
Mar 17, 2016
…c and test ## What changes were proposed in this pull request? Since developer API of plug-able parser has been removed in #10801 , docs should be updated accordingly. ## How was this patch tested? This patch will not affect the real code path. Author: Daoyuan Wang <daoyuan.wang@intel.com> Closes #11758 from adrian-wang/spark12855.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…c and test ## What changes were proposed in this pull request? Since developer API of plug-able parser has been removed in apache#10801 , docs should be updated accordingly. ## How was this patch tested? This patch will not affect the real code path. Author: Daoyuan Wang <daoyuan.wang@intel.com> Closes apache#11758 from adrian-wang/spark12855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the public developer parser API for external parsers. Given everything a parser depends on (e.g. logical plans and expressions) are internal and not stable, external parsers will break with every release of Spark. It is a bad idea to create the illusion that Spark actually supports pluggable parsers. In addition, this also reduces incentives for 3rd party projects to contribute parse improvements back to Spark.