Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12902] [SQL] visualization for generated operators #10828

Closed
wants to merge 8 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Jan 19, 2016

This PR brings back visualization for generated operators, they looks like:

sql

stage

Note: SQL metrics are not supported right now, because they are very slow, will be supported once we have batch mode.

@davies
Copy link
Contributor Author

davies commented Jan 19, 2016

cc @zsxwing

@rxin
Copy link
Contributor

rxin commented Jan 19, 2016

This is pretty cool.

@SparkQA
Copy link

SparkQA commented Jan 19, 2016

Test build #49670 has finished for PR 10828 at commit f0f3da6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies davies changed the title [SPARK-12902] [SQL] visualization and metrics for generated operators [SPARK-12902] [SQL] visualization for generated operators Jan 19, 2016
@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #2412 has finished for PR 10828 at commit 331b46d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jan 20, 2016

@davies did you check if the history server displays this correctly?

@zsxwing
Copy link
Member

zsxwing commented Jan 20, 2016

@davies did you check if the history server displays this correctly?

Just tried it in the history server and it worked correctly. Nice!

@@ -20,6 +20,12 @@
text-shadow: none;
}

#plan-viz-graph svg g.cluster rect {
fill: #E5F2ff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a different style? I think we should make the UI stuff consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one will you suggest? This is outer of operator, should be lighter than that, I choose this because it's between white and the one used for operators.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant using the following style:

#plan-viz-graph svg g.cluster rect {
  fill: #A0DFFF;
  stroke: #3EC0FF;
  stroke-width: 1px;
}

screen shot 2016-01-20 at 10 22 48 am

This looks more consistent with the stage page:
screen shot 2016-01-20 at 10 24 32 am

By the way, I saw a bug in the stage page:
screen shot 2016-01-20 at 10 24 14 am
Could you check it?

@zsxwing
Copy link
Member

zsxwing commented Jan 20, 2016

LGTM except the inconsistent style.

@davies
Copy link
Contributor Author

davies commented Jan 20, 2016

@zsxwing Updated, check that again.

@zsxwing
Copy link
Member

zsxwing commented Jan 20, 2016

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #2421 has finished for PR 10828 at commit a179e8d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jan 20, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #49803 has finished for PR 10828 at commit ccac152.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2423 has finished for PR 10828 at commit ccac152.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jan 21, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2424 has finished for PR 10828 at commit ccac152.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2425 has finished for PR 10828 at commit ccac152.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49825 has finished for PR 10828 at commit ccac152.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49812 has finished for PR 10828 at commit ccac152.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2426 has finished for PR 10828 at commit f5c9087.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2427 has finished for PR 10828 at commit f5c9087.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2428 has finished for PR 10828 at commit f5c9087.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #2430 has finished for PR 10828 at commit 163a014.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2434 has finished for PR 10828 at commit 163a014.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 22, 2016

Test build #2435 has finished for PR 10828 at commit 163a014.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 23, 2016

Test build #2446 has finished for PR 10828 at commit 163a014.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 25, 2016

Test build #2455 has finished for PR 10828 at commit 163a014.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor Author

davies commented Jan 25, 2016

It passed finally, bingo! Merging this into master, thanks!

@asfgit asfgit closed this in 7d877c3 Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants