[SPARK-12926][SQL] SQLContext to display warning message when non-sql configs are being set #10849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working this! I'm worried that throwing an exception could break existing applications (i.e. I know for a fact that spark-sql-perf uses the conf for its own options). What about changing this to a warning? |
Testing:
```
scala> sqlContext.sql("SET spark.shuffle.memoryFraction=0.4")
16/01/21 08:26:47 WARN SQLConf: Attempt to set non-Spark SQL config in SQLConf: key = spark.shuffle.memoryFraction, value = 0.4
res2: org.apache.spark.sql.DataFrame = [key: string, value: string]
scala> sqlContext.getConf("spark.shuffle.memoryFraction")
res3: String = 0.4
```
|
@marmbrus : Makes sense. I have updated the diff with your suggestion. |
|
ping !! |
|
ok to test |
|
Test build #50008 has finished for PR 10849 at commit
|
|
Fixed scala style test |
|
Test build #50082 has finished for PR 10849 at commit
|
|
ping !! |
|
Please update the title and description (these become the commit message when merging). |
tejasapatil
changed the title
|
@marmbrus : Updated the title and description. |
|
Thanks, merging to master. |
|
Thanks, merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users unknowingly try to set core Spark configs in SQLContext but later realise that it didn't work. eg. sqlContext.sql("SET spark.shuffle.memoryFraction=0.4"). This PR adds a warning message when such operations are done.