[SPARK-12624][PYSPARK] Checks row length when converting Java arrays to Python rows #10886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert( | ||
| array.length == fields.length, | ||
| s"Row length ${array.length} and schema length ${fields.length} don't match" | ||
| ) |
There was a problem hiding this comment.
I am wondering if we should throw IllegalStateException because AssertionError can be disabled.
Also, regarding the error message, I wondering if something like The given row does not have the same number of values required by the schema. ${fields.length} values are expected. But, ${array.length} values are provided maybe a better one.
|
Test build #49945 has finished for PR 10886 at commit
|
|
cc @davies |
|
LGTM |
|
Test build #49958 has finished for PR 10886 at commit
|
|
Thanks! Merging to master and branch 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Jan 25, 2016
…to Python rows When actual row length doesn't conform to specified schema field length, we should give a better error message instead of throwing an unintuitive `ArrayOutOfBoundsException`. Author: Cheng Lian <lian@databricks.com> Closes #10886 from liancheng/spark-12624. (cherry picked from commit 3327fd2) Signed-off-by: Yin Huai <yhuai@databricks.com>
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When actual row length doesn't conform to specified schema field length, we should give a better error message instead of throwing an unintuitive
ArrayOutOfBoundsException.