-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12937][SQL] bloom filter serialization #10920
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,10 +55,21 @@ | |
* This implementation is largely based on the {@code CountMinSketch} class from stream-lib. | ||
*/ | ||
abstract public class CountMinSketch { | ||
/** | ||
* Version number of the serialized binary format. | ||
*/ | ||
|
||
public enum Version { | ||
/** | ||
* {@code CountMinSketch} binary format version 1 (all values written in big-endian order): | ||
* - Version number, always 1 (32 bit) | ||
* - Total count of added items (64 bit) | ||
* - Depth (32 bit) | ||
* - Width (32 bit) | ||
* - Hash functions (depth * 64 bit) | ||
* - Count table | ||
* - Row 0 (width * 64 bit) | ||
* - Row 1 (width * 64 bit) | ||
* - ... | ||
* - Row depth - 1 (width * 64 bit) | ||
*/ | ||
V1(1); | ||
|
||
private final int versionNumber; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @liancheng , I removed this as the design doc says users should not care about the version being used. |
||
|
@@ -67,13 +78,11 @@ public enum Version { | |
this.versionNumber = versionNumber; | ||
} | ||
|
||
public int getVersionNumber() { | ||
int getVersionNumber() { | ||
return versionNumber; | ||
} | ||
} | ||
|
||
public abstract Version version(); | ||
|
||
/** | ||
* Returns the relative error (or {@code eps}) of this {@link CountMinSketch}. | ||
*/ | ||
|
@@ -128,13 +137,13 @@ public abstract CountMinSketch mergeInPlace(CountMinSketch other) | |
|
||
/** | ||
* Writes out this {@link CountMinSketch} to an output stream in binary format. | ||
* It is the caller's responsibility to close the stream | ||
* It is the caller's responsibility to close the stream. | ||
*/ | ||
public abstract void writeTo(OutputStream out) throws IOException; | ||
|
||
/** | ||
* Reads in a {@link CountMinSketch} from an input stream. | ||
* It is the caller's responsibility to close the stream | ||
* It is the caller's responsibility to close the stream. | ||
*/ | ||
public static CountMinSketch readFrom(InputStream in) throws IOException { | ||
return CountMinSketchImpl.readFrom(in); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we write the number of hash functions at the end rather than before the words?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Scaladoc requires an extra space before
-
to form an unordered list. I'll fix this one in #10911.