[SPARK-12637] [CORE] Print stage info of finished stages properly #10922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #50103 has finished for PR 10922 at commit
|
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
|
Test build #50270 has finished for PR 10922 at commit
|
|
Test build #50275 has finished for PR 10922 at commit
|
|
retest this please |
| @@ -296,6 +296,17 @@ class StatsReportListener extends SparkListener with Logging { | |||
| taskInfoMetrics.clear() | |||
| } | |||
|
|
|||
| private def getStatusDetail(info: StageInfo): String = { | |||
| val failureReason = info.failureReason.map("(" + _ + ")").getOrElse("") | |||
There was a problem hiding this comment.
why not just do ($failureReason) down there?
There was a problem hiding this comment.
It would produce an empty () when it didn't exist or that was the intent I was just following.
There was a problem hiding this comment.
ah you're right never mind
|
LGTM |
|
Test build #50504 has finished for PR 10922 at commit
|
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve printing of StageInfo in onStageCompleted
See also #10585