[SPARK-12749][SQL] add json option to parse floating-point types as DecimalType #10936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -135,7 +136,10 @@ private[json] object InferSchema { | |||
| DecimalType(v.precision(), v.scale()) | |||
| case FLOAT | DOUBLE => | |||
| // TODO(davies): Should we use decimal if possible? | |||
blbradley
force-pushed
the
spark-12749
branch
from
8cb660a
to
c344359
Compare
|
Test build #2467 has finished for PR 10936 at commit
|
|
I had an unused import. My apologies! |
|
@rxin can you start the test again? |
|
Test build #2469 has finished for PR 10936 at commit
|
|
Sweet. Anything else? |
|
Thanks - I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add this via
USE_BIG_DECIMAL_FOR_FLOATSoption from Jackson with no success.Added test for non-complex types. Should I add a test for complex types?