[SPARK-12938][SQL] DataFrame API for Bloom filter #10937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rxin @liancheng |
cloud-fan
force-pushed
the
bloom-filter
branch
from
139e56f
to
a0dcaa8
Compare
|
Test build #50156 has finished for PR 10937 at commit
|
| val seqOp: (BloomFilter, InternalRow) => BloomFilter = if (colType == StringType) { | ||
| (filter, row) => | ||
| filter.putBinary(row.getUTF8String(0).getBytes) | ||
| filter |
There was a problem hiding this comment.
Also add comment to explain the branching at here?
| @@ -96,6 +96,16 @@ int getVersionNumber() { | |||
| public abstract boolean put(Object item); | |||
|
|
|||
| /** | |||
| * A specific version of {@link #put(Object)}, that can only be used to put byte array. | |||
There was a problem hiding this comment.
specific -> specialized
version -> variant
|
Since the two (cms and bf) are implemented by two different persons, it'd be great for one of you to go through both to make sure everything is consistent. We can do that in a follow-up pull request. |
cloud-fan
force-pushed
the
bloom-filter
branch
from
d4e27bc
to
bd0671c
Compare
|
retest this please |
|
Test build #50208 has finished for PR 10937 at commit
|
|
Thanks - going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates Bloom filter from spark-sketch into DataFrame. This version resorts to RDD.aggregate for building the filter. A more performant UDAF version can be built in future follow-up PRs.
This PR also add 2 specify
putversion(putBinaryandputLong) intoBloomFilter, which makes it easier to build a Bloom filter over aDataFrame.