[ML][PYTHON][SPARK-12834][BACKPORT] Change ser/de of JavaArray and JavaList #10941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.apache.org/jira/browse/SPARK-12834 We use `SerDe.dumps()` to serialize `JavaArray` and `JavaList` in `PythonMLLibAPI`, then deserialize them with `PickleSerializer` in Python side. However, there is no need to transform them in such an inefficient way. Instead of it, we can use type conversion to convert them, e.g. `list(JavaArray)` or `list(JavaList)`. What's more, there is an issue to Ser/De Scala Array as I said in https://issues.apache.org/jira/browse/SPARK-12780 Author: Xusen Yin <yinxusen@gmail.com> Closes apache#10772 from yinxusen/SPARK-12834.
|
Ping @yinxusen I realized we should at least backport this to 1.6. I made this PR to make sure tests run. After this is merged, we can backport [https://github.com/apache/spark/commit/4db255c7aa756daa224d61905db745b6bccc9173] too. |
jkbradley
changed the title
|
Test build #50172 has finished for PR 10941 at commit
|
|
Test build #2465 has finished for PR 10941 at commit
|
|
Sure, LGTM |
|
OK thanks! merging with branch-1.6 |
asfgit
pushed a commit
that referenced
this pull request
Jan 27, 2016
…vaList Backport of SPARK-12834 for branch-1.6 Original PR: #10772 Original commit message: We use `SerDe.dumps()` to serialize `JavaArray` and `JavaList` in `PythonMLLibAPI`, then deserialize them with `PickleSerializer` in Python side. However, there is no need to transform them in such an inefficient way. Instead of it, we can use type conversion to convert them, e.g. `list(JavaArray)` or `list(JavaList)`. What's more, there is an issue to Ser/De Scala Array as I said in https://issues.apache.org/jira/browse/SPARK-12780 Author: Xusen Yin <yinxusen@gmail.com> Closes #10941 from jkbradley/yinxusen-SPARK-12834-1.6.
|
Can you close this PR? (PRs not against master don't auto close) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of SPARK-12834 for branch-1.6
Original PR: #10772
Original commit message:
We use
SerDe.dumps()to serializeJavaArrayandJavaListinPythonMLLibAPI, then deserialize them withPickleSerializerin Python side. However, there is no need to transform them in such an inefficient way. Instead of it, we can use type conversion to convert them, e.g.list(JavaArray)orlist(JavaList). What's more, there is an issue to Ser/De Scala Array as I said in https://issues.apache.org/jira/browse/SPARK-12780