[SPARK-12818][SQL] Specializes integral and string types for Count-min Sketch #10968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,6 +124,18 @@ int getVersionNumber() { | |||
| */ | |||
| public abstract void add(Object item, long count); | |||
|
|
|||
| public abstract void addLong(long item); | |||
There was a problem hiding this comment.
need to add java doc.
also update the other java doc to say "Increment item's count by one." or "Increment item's count by count"
|
Test build #50266 has finished for PR 10968 at commit
|
|
@rxin Updated, thanks for the review! |
liancheng
force-pushed
the
cms-specialized
branch
from
03ea283
to
0d3d009
Compare
liancheng
force-pushed
the
cms-specialized
branch
from
0d3d009
to
463f68a
Compare
|
LGTM |
|
Just reverted all accidental formatting changes made by IntelliJ. |
|
Test build #2468 has finished for PR 10968 at commit
|
|
Test build #50283 has finished for PR 10968 at commit
|
|
LGTM |
|
I'm going to merge this. Thanks. |
liancheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #10911. It adds specialized update methods for
CountMinSketchso that we can avoid doing internal/external row format conversion inDataFrame.countMinSketch().