Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13067][SQL] workaround for a weird scala reflection problem #10970

Closed
wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

A simple workaround to avoid getting parameter types when convert a logical plan to json. Note that this bug only exists locally, but ok on jenkins, not sure why...

@cloud-fan
Copy link
Contributor Author

CC @davies @yhuai @marmbrus

@davies can you try it out locally?

@cloud-fan
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #50316 has finished for PR 10970 at commit 7e66869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #50320 has finished for PR 10970 at commit 7e66869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #2472 has finished for PR 10970 at commit 7e66869.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

"。" replace with "." ?

@davies
Copy link
Contributor

davies commented Jan 29, 2016

Tested it locally, test passed. LGTM, I'm merging this into master, thanks! (fixed the 。)

@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

@cloud-fan is this fixing a bug? If yes, please add a test somewhere.

@asfgit asfgit closed this in 721ced2 Jan 29, 2016
@marmbrus
Copy link
Contributor

Existing tests were failing locally, but not on Jenkins. We are not sure why.

@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

OK got it. @cloud-fan Please add that to the pull request description next time.

@cloud-fan
Copy link
Contributor Author

Sorry I thought the JIRA description tells it, will add it to PR description next time.

@cloud-fan cloud-fan deleted the reflection branch January 29, 2016 07:04
@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

Yea the pull request description gets merged as commit description, and is the only thing that sticks around forever.

@atronchi
Copy link

atronchi commented Sep 2, 2016

How can we workaround this problem when using 1.6.1?

@atronchi
Copy link

atronchi commented Sep 6, 2016

This solution does not seem to work for datasets on tables using complex types. e.g. Array[Int] still throws the exception java.lang.AssertionError: assertion failed: Unsound substitution from List(type T, type U) to List()

@cloud-fan
Copy link
Contributor Author

@atronchi can you create a JIRA and put the code that can reproduce the bug? thanks!

@atronchi
Copy link

atronchi commented Sep 7, 2016

The solution mentioned in [SPARK-17424] by @rdblue fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants