-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13067][SQL] workaround for a weird scala reflection problem #10970
Conversation
retest this please |
Test build #50316 has finished for PR 10970 at commit
|
retest this please |
Test build #50320 has finished for PR 10970 at commit
|
Test build #2472 has finished for PR 10970 at commit
|
"。" replace with "." ? |
Tested it locally, test passed. LGTM, I'm merging this into master, thanks! (fixed the 。) |
@cloud-fan is this fixing a bug? If yes, please add a test somewhere. |
Existing tests were failing locally, but not on Jenkins. We are not sure why. |
OK got it. @cloud-fan Please add that to the pull request description next time. |
Sorry I thought the JIRA description tells it, will add it to PR description next time. |
Yea the pull request description gets merged as commit description, and is the only thing that sticks around forever. |
How can we workaround this problem when using 1.6.1? |
This solution does not seem to work for datasets on tables using complex types. e.g. Array[Int] still throws the exception |
@atronchi can you create a JIRA and put the code that can reproduce the bug? thanks! |
The solution mentioned in [SPARK-17424] by @rdblue fixes this issue. |
A simple workaround to avoid getting parameter types when convert a logical plan to json. Note that this bug only exists locally, but ok on jenkins, not sure why...