Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] [ML] [PySpark] Cleanup test cases of clustering.py #10975

Closed
wants to merge 2 commits into from

Conversation

yanboliang
Copy link
Contributor

Test cases should be removed from annotation of setXXX function, otherwise it will be parts of Python API docs.
cc @mengxr @jkbradley

@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #50346 has finished for PR 10975 at commit 0e749a9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Jan 29, 2016

I don't have strong preference about whether this should live inside the doctest or not. But we need to have this test somewhere to make sure the default value is not changed by accident. @yanboliang Could you add them to the unit test file?

@yanboliang
Copy link
Contributor Author

@mengxr I did not found other class has similar test except KMeans, is this deliberately designed or lacks of some test cases?

@SparkQA
Copy link

SparkQA commented Feb 1, 2016

Test build #50471 has finished for PR 10975 at commit 926ef04.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Feb 11, 2016

Not by design, we just don't have excellent test coverage ...

LGTM. Merged into master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants