Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-12818] Polishes spark-sketch module #10985

Closed
wants to merge 2 commits into from
Closed

[SPARK-12818] Polishes spark-sketch module #10985

wants to merge 2 commits into from

Conversation

liancheng
Copy link
Contributor

Fixes various minor code and Javadoc styling issues.

@liancheng
Copy link
Contributor Author

cc @cloud-fan @rxin

@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

LGTM.

@cloud-fan should review too

cloud-fan
cloud-fan reviewed Jan 29, 2016
View reviewed changes
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java
* has not actually been put in the {@code BloomFilter}.
* Returns the probability that {@linkplain #mightContain(Object)} erroneously return {@code true}
* for an object that has not actually been put in the
* {@code BloomFilter}).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra )?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch.

@cloud-fan
Copy link
Contributor

LGTM, thanks a lot!

@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #50399 has finished for PR 10985 at commit 605b011.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final class BitArray
    • class BloomFilterImpl extends BloomFilter implements Serializable
    • class Utils

@liancheng
Copy link
Contributor Author

Thanks for the review, merging to master.

@asfgit asfgit closed this in 2b027e9 Jan 29, 2016
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50403/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@liancheng @rxin @cloud-fan @SparkQA @AmplabJenkins