[SPARK-13113][Core] Remove unnecessary bit operation when decoding page number #11002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +312,7 @@ public static long encodePageNumberAndOffset(int pageNumber, long offsetInPage) | |||
|
|
|||
| @VisibleForTesting | |||
| public static int decodePageNumber(long pagePlusOffsetAddress) { | |||
| return (int) ((pagePlusOffsetAddress & MASK_LONG_UPPER_13_BITS) >>> OFFSET_BITS); | |||
| return (int) (pagePlusOffsetAddress >> OFFSET_BITS); | |||
There was a problem hiding this comment.
Are we absolutely sure that the top bit is not used?
There was a problem hiding this comment.
Ah, it should be >>> not >>. I will update this.
|
Test build #50486 has finished for PR 11002 at commit
|
viirya
force-pushed
the
improve-decodepagenumber
branch
from
7f1439b
to
4b846dd
Compare
|
retest this please. |
|
Test build #50489 has finished for PR 11002 at commit
|
viirya
changed the title
|
This change looks good to me, maybe @JoshRosen who was the last to touch that line can take a look? |
|
Seems OK, are there other redundant usages? The constant name including 13 seems overly specific too |
|
I will check again. But yesterday I just found this. |
|
Hmm, I just found this after another check. |
|
@davies Can you take a look if this is proper to merge? Thanks. |
|
LGTM, merging this into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-13113
As we shift bits right, looks like the bitwise AND operation is unnecessary.