Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-13094][SQL] Add encoders for seq/array of primitives #11014

Closed
wants to merge 2 commits into from
Closed

[SPARK-13094][SQL] Add encoders for seq/array of primitives #11014

wants to merge 2 commits into from

Conversation

marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Feb 2, 2016

No description provided.

@SparkQA
Copy link

SparkQA commented Feb 2, 2016

Test build #50523 has finished for PR 11014 at commit 1c2f67d.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 2, 2016

Test build #50528 has finished for PR 11014 at commit ae356d1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Feb 2, 2016

Can we add support for Java?

@marmbrus
Copy link
Contributor Author

marmbrus commented Feb 2, 2016

Sure, but I don't think we want to just enumerate in that API like we have to here for implicits to work. Instead we should do something like we do for tuples where you can compose. I'll defer that to SPARK-13128 so this can make 1.6.1.

cloud-fan
cloud-fan reviewed Feb 2, 2016
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala
implicit def newBooleanSeqEncoder: Encoder[Seq[Boolean]] = ExpressionEncoder()

/** @since 1.6.1 */
implicit def newStringSeqEncoder: Encoder[Seq[String]] = ExpressionEncoder()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about seq of product?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i went back and forth on that. I guess its probably useful.

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Feb 2, 2016

Test build #50538 has finished for PR 11014 at commit 0b5f03c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Feb 2, 2016
@marmbrus
[SPARK-13094][SQL] Add encoders for seq/array of primitives
99594b2 
Author: Michael Armbrust <michael@databricks.com>

Closes #11014 from marmbrus/seqEncoders.

(cherry picked from commit 29d9218)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 29d9218 Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@marmbrus @SparkQA @rxin @cloud-fan