Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13126] fix the right margin of history page. #11029

Closed
wants to merge 1 commit into from

Conversation

zhuoliu
Copy link

@zhuoliu zhuoliu commented Feb 2, 2016

The right margin of the history page is little bit off. A simple fix for that issue.

@ajbozarth
Copy link
Member

Can you post a screenshot?

@zhuoliu
Copy link
Author

zhuoliu commented Feb 2, 2016

history-margin
Sure.

@ajbozarth
Copy link
Member

It looks a bit off to me when I make the window wider
page_width_fixed

@andrewor14
Copy link
Contributor

ok to test

@andrewor14
Copy link
Contributor

@zhuoliu is your screenshot before or after? Can you post both of them so we can compare?

@ajbozarth
Copy link
Member

@andrewor14 I posted this before in the jira:
page_width

@zhuoliu
Copy link
Author

zhuoliu commented Feb 3, 2016

Hi @ajbozarth , the screenshot you pasted is a little different from mine since your date and app-Id are wrapped into two lines while there is still lots of space on the right side.

In my test, when you drag your browser to be too wide, there do exist white space on the right side.
Would be happy if we can come up with a better solution than disabling the "row-fluid".
Thanks.

@ajbozarth
Copy link
Member

Looked through all 4500 results in my history server (glad it was that short) and found this guy:
width_long_name
Seems that DataTables formats for the entire table not just the currently visible. I think we should change it if possible, but it's a problem irrelevant to this particular fix.

So LGTM and I'll file a Jira on the other issue.

@ajbozarth
Copy link
Member

Jenkins has been giving me problems too. Jenkins retest this please.

@SparkQA
Copy link

SparkQA commented Feb 3, 2016

Test build #50673 has finished for PR 11029 at commit 564966d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ajbozarth
Copy link
Member

@tgravescs also a fix on the DataTables addition if you want to take a look

@tgravescs
Copy link
Contributor

+1

@asfgit asfgit closed this in 4b80026 Feb 10, 2016
superbobry pushed a commit to criteo-forks/spark that referenced this pull request Feb 15, 2017
The right margin of the history page is little bit off. A simple fix for that issue.

Author: zhuol <zhuol@yahoo-inc.com>

Closes apache#11029 from zhuoliu/13126.
superbobry pushed a commit to criteo-forks/spark that referenced this pull request Mar 20, 2017
The right margin of the history page is little bit off. A simple fix for that issue.

Author: zhuol <zhuol@yahoo-inc.com>

Closes apache#11029 from zhuoliu/13126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants