[SPARK-13153][PySpark] ML persistence failed when handle no default value parameter #11043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,8 +79,9 @@ def _transfer_params_from_java(self): | |||
| for param in self.params: | |||
| if self._java_obj.hasParam(param.name): | |||
| java_param = self._java_obj.getParam(param.name) | |||
| value = _java2py(sc, self._java_obj.getOrDefault(java_param)) | |||
| self._paramMap[param] = value | |||
| if self._java_obj.hasDefault(java_param): | |||
There was a problem hiding this comment.
We should check by isDefined rather than hasDefault here.
|
ping @mengxr @jkbradley |
|
It's OK now and ready to launch test. |
|
ok to test |
|
LGTM pending Jenins |
|
Test build #51161 has finished for PR 11043 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Feb 12, 2016
…alue parameter Fix this defect by check default value exist or not. yanboliang Please help to review. Author: Tommy YU <tummyyu@163.com> Closes #11043 from Wenpei/spark-13153-handle-param-withnodefaultvalue. (cherry picked from commit d3e2e20) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
Merged into master and branch-1.6. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this defect by check default value exist or not.
@yanboliang Please help to review.