[SPARK-13152][CORE] Fix task metrics deprecation warning #11056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sRead so we don't have unecessary deprecation warnings in our build.
holdenk
changed the title
|
also cc @srowen who was interested |
| @@ -81,10 +81,14 @@ class InputMetrics private ( | |||
| */ | |||
| def readMethod: DataReadMethod.Value = DataReadMethod.withName(_readMethod.localValue) | |||
|
|
|||
| // Once incBytesRead & intRecordsRead is ready to be removed from the public API | |||
| // we can remove the internal versions and make the previous public API private. | |||
There was a problem hiding this comment.
can you add that this is to suppress warnings?
|
LGTM |
|
Test build #50677 has finished for PR 11056 at commit
|
|
retest this please |
|
Test build #50683 has finished for PR 11056 at commit
|
|
Test build #50692 has finished for PR 11056 at commit
|
|
Merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make an internal non-deprecated version of incBytesRead and incRecordsRead so we don't have unecessary deprecation warnings in our build.
Right now incBytesRead and incRecordsRead are marked as deprecated and for internal use only. We should make private[spark] versions which are not deprecated and switch to those internally so as to not clutter up the warning messages when building.
cc @andrewor14 who did the initial deprecation