Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13168][SQL] Collapse adjacent repartition operators #11064

Closed
wants to merge 3 commits into from

Conversation

JoshRosen
Copy link
Contributor

Spark SQL should collapse adjacent Repartition operators and only keep the last one.

@JoshRosen JoshRosen changed the title [SPARK-13168][SQL] Collapse adjacent repartition operators. [SPARK-13168][SQL] Collapse adjacent repartition operators Feb 3, 2016
@@ -223,6 +222,18 @@ class PlannerSuite extends SharedSQLContext {
}
}

test("collapse adjacent repartitions") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that this test is in the wrong place; it should be grouped with the other per-optimizer-rule suites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to leave this here for now; this test isn't likely to be brittle and we don't really need other more complex tests for this feature, so it's fine to have a somewhat more end-to-end whole-optimizer test for this here.

@SparkQA
Copy link

SparkQA commented Feb 4, 2016

Test build #50698 has finished for PR 11064 at commit 82b9517.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Feb 4, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Feb 4, 2016

Test build #2515 has finished for PR 11064 at commit 6ea10ff.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@andrewor14
Copy link
Contributor

LGTM, straightforward change.

@SparkQA
Copy link

SparkQA commented Feb 4, 2016

Test build #50753 has finished for PR 11064 at commit 6ea10ff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Merged into master.

@asfgit asfgit closed this in 33212cb Feb 4, 2016
@JoshRosen JoshRosen deleted the collapse-repartition branch February 4, 2016 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants