[SPARK-12828][SQL] Natural join follow-up #11070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,10 +30,10 @@ class ResolveNaturalJoinSuite extends AnalysisTest { | |||
| lazy val aNotNull = a.notNull | |||
| lazy val bNotNull = b.notNull | |||
| lazy val cNotNull = c.notNull | |||
| lazy val r1 = LocalRelation(a, b) | |||
| lazy val r2 = LocalRelation(a, c) | |||
| lazy val r1 = LocalRelation(b, a) | |||
There was a problem hiding this comment.
switching the order here more properly test the reordering of output projection.
|
cc @adrian-wang |
|
LGTM, thx! |
|
Test build #50737 has finished for PR 11070 at commit
|
|
Merging in master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small addendum to #10762 to make the code more robust again future changes.