Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13171] [Core] Replace future calls with Future #11085

Closed
wants to merge 3 commits into from
Closed

[SPARK-13171] [Core] Replace future calls with Future #11085

wants to merge 3 commits into from

Conversation

jodersky
Copy link
Member

@jodersky jodersky commented Feb 5, 2016

Trivial search-and-replace to eliminate deprecation warnings in Scala 2.11.
Also works with 2.10

@andrewor14
Copy link
Contributor

add to whitelist

@andrewor14
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Feb 5, 2016

Test build #50791 has finished for PR 11085 at commit e7bfb13.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jodersky
Copy link
Member Author

jodersky commented Feb 5, 2016

retest please

@SparkQA
Copy link

SparkQA commented Feb 5, 2016

Test build #50799 has finished for PR 11085 at commit 40fe8a4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jodersky
Copy link
Member Author

jodersky commented Feb 5, 2016

seems to have been caused by something unrelated, retest please

@gatorsmile
Copy link
Member

retest this please

@gatorsmile
Copy link
Member

@jodersky Just FYI, the commands you can use are listed below:

  - "ok to test" to accept this pull request for testing
  - "test this please" for a one time test run
  - "retest this please" to start a new build

@jodersky
Copy link
Member Author

jodersky commented Feb 5, 2016

thanks, I didn't know that :)

@SparkQA
Copy link

SparkQA commented Feb 5, 2016

Test build #50808 has finished for PR 11085 at commit 40fe8a4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Feb 5, 2016

Test build #50829 has finished for PR 11085 at commit 40fe8a4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Feb 5, 2016

Seems like there is a legitimate compilation failure?

@jodersky
Copy link
Member Author

jodersky commented Feb 5, 2016

yeah 3 fails in a row, I'll take a look at it

@jodersky
Copy link
Member Author

jodersky commented Feb 5, 2016

I rebased on master and ran local tests successfully

@jodersky
Copy link
Member Author

jodersky commented Feb 5, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Feb 6, 2016

Test build #50846 has finished for PR 11085 at commit 055d9c9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jodersky
Copy link
Member Author

jodersky commented Feb 6, 2016

My local tests didn't include the hive profiles, where the error is originating from.
Retest this please

@SparkQA
Copy link

SparkQA commented Feb 6, 2016

Test build #50852 has finished for PR 11085 at commit 4078df0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Feb 6, 2016

Thanks - merging in master.

@asfgit asfgit closed this in 6883a51 Feb 6, 2016
@gatorsmile
Copy link
Member

I am afraid all the recent failure of test cases in HiveSparkSubmitSuite are caused by this merge.

Since this merge, I saw the same errors repeat
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50868/consoleFull
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50869/consoleFull
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50871/consoleFull
...

@jodersky
Copy link
Member Author

jodersky commented Feb 6, 2016

Someone else also reported that problem. Check out the discussion on the JIRA https://issues.apache.org/jira/browse/SPARK-13171

@gatorsmile
Copy link
Member

Thank you for your investigation! Maybe we can let the committers revert this merge or disable these Flaky tests?

cc @rxin @JoshRosen @davies @andrewor14

@gatorsmile
Copy link
Member

BTW, I also hit similar issues without this merge in my local environment. Thus, I do not know what is the root causes of this problem.

@jodersky jodersky deleted the SPARK-13171 branch February 11, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants