[SPARK-13170] [STREAMING] Investigate replacing SynchronizedQueue as it is deprecated #11111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +65,7 @@ class InputStreamsSuite extends TestSuiteBase with BeforeAndAfter { | |||
| // Feed data to the server to send to the network receiver | |||
| val clock = ssc.scheduler.clock.asInstanceOf[ManualClock] | |||
| val expectedOutput = input.map(_.toString) | |||
| for (i <- 0 until input.size) { | |||
| for (i <- input.indices) { | |||
There was a problem hiding this comment.
OK, I touched this up in other code I was touching, and then wanted to do it everywhere in this file.
|
Test build #50903 has finished for PR 11111 at commit
|
|
This looks good to me, and it looks like we synchronize on the same object that the deprecated SynchronizedQueue did so it should still be ok for peoples code that was written using that. |
|
Agreed, I also just compared it with the SynchronizedQueue sources and behaviour should be identical. looks good |
|
Test build #50964 has finished for PR 11111 at commit
|
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace SynchronizeQueue with synchronized access to a Queue