New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13265][ML] Refactoring of basic ML import/export for other file system besides HDFS #11151

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@yu-iskw
Contributor

yu-iskw commented Feb 10, 2016

@jkbradley I tried to improve the function to export a model. When I tried to export a model to S3 under Spark 1.6, we couldn't do that. So, it should offer S3 besides HDFS. Can you review it when you have time? Thanks!

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Feb 10, 2016

Test build #51036 has finished for PR 11151 at commit 5f0092f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Feb 10, 2016

Test build #51036 has finished for PR 11151 at commit 5f0092f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@yu-iskw

This comment has been minimized.

Show comment
Hide comment
@yu-iskw

yu-iskw Feb 11, 2016

Contributor

cc @mengxr

Contributor

yu-iskw commented Feb 11, 2016

cc @mengxr

@mengxr

This comment has been minimized.

Show comment
Hide comment
@mengxr

mengxr Feb 11, 2016

Contributor

LGTM. Merged into master and branch-1.6. Thanks! Btw, this happens when the default file system is not the same as the file system of the output path. I don't know whether we have a good way to unit test it. It won't be nice to add a test to prevent future errors.

Contributor

mengxr commented Feb 11, 2016

LGTM. Merged into master and branch-1.6. Thanks! Btw, this happens when the default file system is not the same as the file system of the output path. I don't know whether we have a good way to unit test it. It won't be nice to add a test to prevent future errors.

@asfgit asfgit closed this in efb65e0 Feb 11, 2016

asfgit pushed a commit that referenced this pull request Feb 11, 2016

[SPARK-13265][ML] Refactoring of basic ML import/export for other fil…
…e system besides HDFS

jkbradley I tried to improve the function to export a model. When I tried to export a model to S3 under Spark 1.6, we couldn't do that. So, it should offer S3 besides HDFS. Can you review it when you have time? Thanks!

Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>

Closes #11151 from yu-iskw/SPARK-13265.

(cherry picked from commit efb65e0)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@yu-iskw

This comment has been minimized.

Show comment
Hide comment
@yu-iskw

yu-iskw Feb 11, 2016

Contributor

Thank you for merging it.

Contributor

yu-iskw commented Feb 11, 2016

Thank you for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment