[STREAMING][TEST] Fix flaky streaming.FailureSuite #11166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zsxwing Could you take a look at this. |
| @@ -43,6 +43,9 @@ class FailureSuite extends SparkFunSuite with BeforeAndAfter with Logging { | |||
| Utils.deleteRecursively(directory) | |||
| } | |||
| StreamingContext.getActive().foreach { _.stop() } | |||
|
|
|||
| // Stop SparkContext if active | |||
| SparkContext.getOrCreate(new SparkConf().setMaster("local").setAppName("bla")).stop() | |||
There was a problem hiding this comment.
could you explain where leaks SparkContext? I cannot find any clue from the log
There was a problem hiding this comment.
I am not entirely sure. I think somehow a StreamingContext is not shutdown cleanly, which causes the SparkContext to leak. This fix at least prevents the issue to cascade to other testsuites.
|
Test build #51079 has finished for PR 11166 at commit
|
|
LGTM. Merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some corner cases, the test suite failed to shutdown the SparkContext causing cascaded failures. This fix does two things