[SPARK-13282][SQL] LogicalPlan toSql should just return a String #11171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liancheng |
|
Test build #51093 has finished for PR 11171 at commit
|
|
|
||
| case _ => None | ||
| case _ => | ||
| throw new UnsupportedOperationException("") |
There was a problem hiding this comment.
Probably not using empty error message here?
…er than Option[String]
|
Updated. cc @gatorsmile unfortunately you will have to rebase your pull requests, although it should be easy to do. |
|
Test build #51178 has finished for PR 11171 at commit
|
|
It is easy to rebase. After the merge, I will submit PRs for the other related JIRAs. Thanks! |
|
Thanks - I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using Option[String] and None to indicate the case when Spark fails to generate SQL. It is easier to just use exceptions to propagate error cases, rather than having for comprehension everywhere. I also introduced a "build" function that simplifies string concatenation (i.e. no need to reason about whether we have an extra space or not).