[SPARK-13279] Remove unnecessary duplicate check in addPendingTask fu… #11175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins this is ok to test |
|
Jenkins, test this please |
| if (!list.contains(index)) { | ||
| list += index | ||
| } | ||
| list += index | ||
| } |
There was a problem hiding this comment.
It strikes me that addTo is now only making a negative contribution toward understanding the code -- mostly because the "...if it's not already there" comment is now wrong. I don't see why the handful of uses of addTo shouldn't just be replaced with, e.g.:
pendingTasksForExecutor.getOrElseUpdate(e.executorId, new ArrayBuffer) += index
sitalkedia
force-pushed
the
fix_stuck_driver
branch
from
3fe1af8
to
a0c3512
Compare
sitalkedia
force-pushed
the
fix_stuck_driver
branch
from
a0c3512
to
26b4370
Compare
|
Jenkins, test this please |
|
Test build #51266 has finished for PR 11175 at commit
|
|
@kayousterhout I'll let you push the button on this one when you're sure but it looks OK to me. |
|
@kayousterhout did you get some time to look into this? |
asfgit
pushed a commit
that referenced
this pull request
Feb 17, 2016
This commit removes an unnecessary duplicate check in addPendingTask that meant that scheduling a task set took time proportional to (# tasks)^2. Author: Sital Kedia <skedia@fb.com> Closes #11175 from sitalkedia/fix_stuck_driver. (cherry picked from commit 1e1e31e) Signed-off-by: Kay Ousterhout <kayousterhout@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nction