Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13300][Documentation] Added pygments.rb dependancy #11180

Closed
wants to merge 2 commits into from
Closed

[SPARK-13300][Documentation] Added pygments.rb dependancy #11180

wants to merge 2 commits into from

Conversation

amitdev
Copy link
Contributor

@amitdev amitdev commented Feb 12, 2016

Looks like pygments.rb gem is also required for jekyll build to work. At least on Ubuntu/RHEL I could not do build without this dependency. So added this to steps.

@amitdev amitdev changed the title Added pygments.rb dependancy [Documentation] Added pygments.rb dependancy Feb 12, 2016
@mengxr
Copy link
Contributor

mengxr commented Feb 12, 2016

@amitdev The PR also contains ml-guide changes. Could you remove that commit from your branch?

@amitdev
Copy link
Contributor Author

amitdev commented Feb 12, 2016

@mengxr, Sorry I committed that by mistake - removed now. Thanks!

@srowen
Copy link
Member

srowen commented Feb 12, 2016

@amitdev can you connect this to https://issues.apache.org/jira/browse/SPARK-13300 in the title? it might be the same thing?

It looks like lots of the examples aren't rendered in the current live site?
http://spark.apache.org/examples.html

@amitdev
Copy link
Contributor Author

amitdev commented Feb 13, 2016

@srowen, it looks related - is there a way to verify it? I couldn't locate where the spark example code is. Things on the main documentation site is working fine. Anyway I'll change the title so that someone with access can take a look.

@amitdev amitdev changed the title [Documentation] Added pygments.rb dependancy [SPARK-13300][Documentation] Added pygments.rb dependancy Feb 13, 2016
@srowen
Copy link
Member

srowen commented Feb 13, 2016

@amitdev just build the documentation. Do you see the code snippets correctly in the page http://spark.apache.org/examples.html in your local build? instead of the pygments error?

@srowen
Copy link
Member

srowen commented Feb 13, 2016

Aha, one significant update. Yes, the change here is a good one, as I also had to install this gem to build the docs. In fact we can simplify:

sudo gem install jekyll jekyll-redirect-from pygments.rb
sudo pip install Pygments sphinx

Maybe it's also worth noting that you'd have to have Ruby and pip installed (and I assume gcc, Python already), which may not be obvious. For Ubuntu that's:

sudo apt-get install ruby ruby-dev pip-python

I don't feel strongly about adding that, but hey.

Actually I was incorrect in connecting this to SPARK-13300 though, as the page in question is not generated from source in docs/. It's part of the ASF site. This also uses pygments though. So maybe it turns out to be the same problem.

While we can just add this change (with a possible simplification) I'm also looking at whether I can fix up the ASF site with something similar.

@srowen
Copy link
Member

srowen commented Feb 13, 2016

I fixed the ASF site at http://spark.apache.org/examples.html and indeed it required the same gem to be installed to work. So this is related.

@amitdev
Copy link
Contributor Author

amitdev commented Feb 14, 2016

Thanks @srowen. I've mentioned dependencies on Ruby, Python and cleaned up the doc a little.

@srowen
Copy link
Member

srowen commented Feb 14, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Feb 14, 2016

Test build #51265 has finished for PR 11180 at commit 044b0d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Feb 14, 2016
Looks like pygments.rb gem is also required for jekyll build to work. At least on Ubuntu/RHEL I could not do build without this dependency. So added this to steps.

Author: Amit Dev <amitdev@gmail.com>

Closes #11180 from amitdev/master.

(cherry picked from commit 331293c)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Feb 14, 2016

Merged to master/1.6. @amitdev if you'll tell me your JIRA handle I'll assign you.

@asfgit asfgit closed this in 331293c Feb 14, 2016
@amitdev
Copy link
Contributor Author

amitdev commented Feb 15, 2016

@srowen, my JIRA handle is amitdev.

@srowen
Copy link
Member

srowen commented Feb 15, 2016

@amitdev I don't see anyone by your name or "Amit Dev.." in ASF JIRA. Are you sure? maybe link me to your profile page

@amitdev
Copy link
Contributor Author

amitdev commented Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants