[SPARK-13351] [SQL] fix column pruning on Expand #11225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #51397 has finished for PR 11225 at commit
|
| @@ -300,6 +300,16 @@ object SetOperationPushDown extends Rule[LogicalPlan] with PredicateHelper { | |||
| */ | |||
| object ColumnPruning extends Rule[LogicalPlan] { | |||
| def apply(plan: LogicalPlan): LogicalPlan = plan transform { | |||
| case a @ Aggregate(_, _, e @ Expand(projects, output, child)) | |||
There was a problem hiding this comment.
To summarize my understanding for other reviewers:
This new rule handles the case where you have an expand beneath an aggregate and the expand produces rows with columns which are not referenced by the aggregate operator. In this case, we want to rewrite the expand's projections in order to eliminate the unreferenced column.
|
LGTM. This change looks correct to me. I'm going to merge this PR into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the columns in projects of Expand that are not used by Aggregate are not pruned, this PR fix that.