[SPARK-13358][SQL] Retrieve grep path when do benchmark #11231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,8 @@ private[spark] object Benchmark { | |||
| if (SystemUtils.IS_OS_MAC_OSX) { | |||
| Utils.executeAndGetOutput(Seq("/usr/sbin/sysctl", "-n", "machdep.cpu.brand_string")) | |||
| } else if (SystemUtils.IS_OS_LINUX) { | |||
| Utils.executeAndGetOutput(Seq("/usr/bin/grep", "-m", "1", "\"model name\"", "/proc/cpuinfo")) | |||
| val grepPath = Utils.executeAndGetOutput(Seq("which", "grep")) | |||
| Utils.executeAndGetOutput(Seq(grepPath, "-m", "1", "model name", "/proc/cpuinfo")) | |||
There was a problem hiding this comment.
""model name"" doesn't work on my linux. "model name" works. Don't know if it is special case or general.
|
retest this please. |
|
Test build #51406 has finished for PR 11231 at commit
|
| @@ -93,7 +93,8 @@ private[spark] object Benchmark { | |||
| if (SystemUtils.IS_OS_MAC_OSX) { | |||
| Utils.executeAndGetOutput(Seq("/usr/sbin/sysctl", "-n", "machdep.cpu.brand_string")) | |||
| } else if (SystemUtils.IS_OS_LINUX) { | |||
| Utils.executeAndGetOutput(Seq("/usr/bin/grep", "-m", "1", "\"model name\"", "/proc/cpuinfo")) | |||
There was a problem hiding this comment.
Or just make it "grep" without specified path?
|
I guess there isn't a way to test this... Lemme try this locally. |
|
This works on my linux machine (Ubuntu 15.10). |
|
Test build #51466 has finished for PR 11231 at commit
|
|
ping @davies do you think this is useful? Thanks. |
|
LGTM, merging into master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-13358
When trying to run a benchmark, I found that on my Ubuntu linux grep is not in /usr/bin/ but /bin/. So wondering if it is better to use which to retrieve grep path.
cc @davies