[SPARK-13389] [SparkR] SparkR support first/last with ignore NAs #11267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #51546 has finished for PR 11267 at commit
|
|
Is this option used by base R / other R libraries like dplyr ? |
| function(x) { | ||
| jc <- callJStatic("org.apache.spark.sql.functions", "first", x@jc) | ||
| signature(x = "characterOrColumn"), | ||
| function(x, ignoreNAs = FALSE) { |
There was a problem hiding this comment.
probably something like na.rm=TRUE would be more R like
or na.omit
There was a problem hiding this comment.
Make sense, I will update. Thanks!
|
@shivaram Several R packages have similar function such as first, aggregate, etc. Users need this feature in R and did some workaround. |
|
Test build #51656 has finished for PR 11267 at commit
|
|
Thanks @yanboliang -- Sorry for the delay in looking at this. I think this looks good. Merging to master |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? SparkR support first/last with ignore NAs cc sun-rui felixcheung shivaram ## How was the this patch tested? unit tests Author: Yanbo Liang <ybliang8@gmail.com> Closes apache#11267 from yanboliang/spark-13389.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SparkR support first/last with ignore NAs
cc @sun-rui @felixcheung @shivaram
How was the this patch tested?
unit tests