[SPARK-13442][SQL] Make type inference recognize boolean types #11315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #51713 has finished for PR 11315 at commit
|
|
cc @falaki @yucheng1992 Would you review this please? |
|
@HyukjinKwon I think it's good. Thanks! |
|
LGTM pending tests |
|
Test build #52308 has finished for PR 11315 at commit
|
|
cc @rxin |
|
Thanks - merging in master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-13442 This PR adds the support for inferring `BooleanType` for schema. It supports to infer case-insensitive `true` / `false` as `BooleanType`. Unittests were added for `CSVInferSchemaSuite` and `CSVSuite` for end-to-end test. ## How was the this patch tested? This was tested with unittests and with `dev/run_tests` for coding style Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#11315 from HyukjinKwon/SPARK-13442.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-13442
This PR adds the support for inferring
BooleanTypefor schema.It supports to infer case-insensitive
true/falseasBooleanType.Unittests were added for
CSVInferSchemaSuiteandCSVSuitefor end-to-end test.How was the this patch tested?
This was tested with unittests and with
dev/run_testsfor coding style