[SPARK-13479] [SQL] [PYTHON] Added Python API for approxQuantile #11356
Conversation
jkbradley
changed the title
|
CC: @mengxr @thunterdb |
|
Test build #51913 has finished for PR 11356 at commit
|
| */ | ||
| def approxQuantile( | ||
| col: String, | ||
| probabilities: List[Double], |
There was a problem hiding this comment.
maybe java.util.List to make it very explicit this is a java list, not a scala list ...
|
Test build #51916 has finished for PR 11356 at commit
|
|
Weird...the method works for me locally. |
|
oh nevermind, I didn't test the last commit properly. I'll send a fix |
| * Note that values greater than 1 are accepted but give the same result as 1. | ||
| * @return the approximate quantiles at the given probabilities | ||
| * | ||
| * @since 2.0.0 |
There was a problem hiding this comment.
This is a package private API. Maybe we should simply say "Python-friendly version of [[...]].`.
There was a problem hiding this comment.
I would have, but I was just following other conventions in the DataFrame code. I'll change it though.
… type for simpler Python wrapper
|
LGTM |
|
Test build #51932 has finished for PR 11356 at commit
|
|
Test build #51933 has finished for PR 11356 at commit
|
|
Merged into master. Thanks! |
What changes were proposed in this pull request?
How was this patch tested?
Documentation was copied from the existing approxQuantile exactly.